Add ThriftTransport constructor taking plain EventBase

Summary:
Currently, the generated `ThriftTransport` constructor accepts a `VirtualEventBase&`. This is for consistency
with `AsyncMcClient` code. However, currently `ThriftTransport` doesn't use the virtual-ness of `VirtualEventBase` at all
and simply directly uses the backing `EventBase`. For tests, it would be convenient to be able to construct a `ThriftTransport`
directly from `EventBase`, which is what this diff adds.

Reviewed By: stuclar

Differential Revision: D17056270

fbshipit-source-id: f968417e95952f48c58c087bf0d3d4035ee46267

mcrouter/lib/carbon/example/gen/HelloGoodbyeThriftTransport.h

@@ -31,8 +31,10 @@ namespace memcache {
 template <>
 class ThriftTransport<hellogoodbye::HelloGoodbyeRouterInfo> : public ThriftTransportBase {
  public:
-  ThriftTransport(folly::VirtualEventBase& eventBase, ConnectionOptions options)
+  ThriftTransport(folly::EventBase& eventBase, ConnectionOptions options)
       : ThriftTransportBase(eventBase, std::move(options)) {}
+  ThriftTransport(folly::VirtualEventBase& eventBase, ConnectionOptions options)
+      : ThriftTransportBase(eventBase.getEventBase(), std::move(options)) {}
   ~ThriftTransport() override final = default;
 
   void setFlushList(FlushList* flushList) override final {

mcrouter/lib/network/ThriftTransport.cpp

@@ -8,7 +8,6 @@
 
 #include <folly/fibers/FiberManager.h>
 #include <folly/io/async/EventBase.h>
-#include <folly/io/async/VirtualEventBase.h>
 #include <thrift/lib/cpp/async/TAsyncSocket.h>
 #include <thrift/lib/cpp2/async/RequestChannel.h>
 
@@ -24,10 +23,9 @@ namespace facebook {
 namespace memcache {
 
 ThriftTransportBase::ThriftTransportBase(
-    folly::VirtualEventBase& eventBase,
+    folly::EventBase& eventBase,
     ConnectionOptions options)
-    : eventBase_(eventBase.getEventBase()),
-      connectionOptions_(std::move(options)) {}
+    : eventBase_(eventBase), connectionOptions_(std::move(options)) {}
 
 void ThriftTransportBase::closeNow() {
   resetClient();

mcrouter/lib/network/ThriftTransport.h

@@ -37,9 +37,7 @@ class ThriftTransportBase : public Transport,
                             private folly::AsyncSocket::ConnectCallback,
                             private apache::thrift::CloseCallback {
  public:
-  ThriftTransportBase(
-      folly::VirtualEventBase& eventBase,
-      ConnectionOptions options);
+  ThriftTransportBase(folly::EventBase& eventBase, ConnectionOptions options);
   virtual ~ThriftTransportBase() override = default;
 
   static constexpr folly::StringPiece name() {
@@ -127,7 +125,7 @@ template <class RouterInfo>
 class ThriftTransport : public ThriftTransportBase {
  public:
   ThriftTransport(folly::VirtualEventBase& eventBase, ConnectionOptions options)
-      : ThriftTransportBase(eventBase, std::move(options)) {}
+      : ThriftTransportBase(eventBase.getEventBase(), std::move(options)) {}
   ~ThriftTransport() override final = default;
 
   template <class Request>

mcrouter/lib/network/gen/MemcacheThriftTransport.h

@@ -31,8 +31,10 @@ namespace memcache {
 template <>
 class ThriftTransport<MemcacheRouterInfo> : public ThriftTransportBase {
  public:
-  ThriftTransport(folly::VirtualEventBase& eventBase, ConnectionOptions options)
+  ThriftTransport(folly::EventBase& eventBase, ConnectionOptions options)
       : ThriftTransportBase(eventBase, std::move(options)) {}
+  ThriftTransport(folly::VirtualEventBase& eventBase, ConnectionOptions options)
+      : ThriftTransportBase(eventBase.getEventBase(), std::move(options)) {}
   ~ThriftTransport() override final = default;
 
   void setFlushList(FlushList* flushList) override final {