Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission] Added translation for the "add new post" button for all available languages #876

Conversation

kivuvarosekivuvan
Copy link
Contributor

@kivuvarosekivuvan kivuvarosekivuvan commented Mar 13, 2024

Engineers Checklist

What this PR does?

  • Adds translation on the "add new post" button for all the available languages because the button initially was in english across all the languages.

How can it be tested?

  • Launch the local server
  • Login/signup to the platform
  • Navigate to the language setting at the top right part of the (default) page
  • Chose a specific language and check on the "add new post" button on the sidebar to confirm if language changes.

Where is it documented?

What would be the Impact of this solution

  • Users will be able to use the platform comfortably and create posts in the language they understand best. It promotes inclusivity and improves the overall user experience.

UI Update

The button translated -- some few language demo

Group 8

Group 7

Group 6

@kivuvarosekivuvan
Copy link
Contributor Author

@ushahidlee and @Angamanga, I have developed a solution from an issue I raised, could you kindly review this and give me your thoughts

@Angamanga Angamanga self-requested a review March 15, 2024 14:25
@MugoBrian
Copy link
Contributor

MugoBrian commented Mar 21, 2024

Hello @kivuvarosekivuvan , this PR is solving multiple issues according to your commits. Or are the first four commits related to the last commit?

Tip: If not, it's advisable to separate those related commits into another PR, one PR fixing the issue of the cancel button in the popup modal, the second PR for fixing the Add new post button for all available languages issue.

@kivuvarosekivuvan kivuvarosekivuvan force-pushed the feature/btn-language-translation branch 2 times, most recently from 509770e to eb45ebe Compare March 21, 2024 16:37
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kivuvarosekivuvan! While this is an excellent and valuable contribution, our translations are actually stored in and fetched from a tool called transifex, and that is where all translations except the en.json gets added. Translations are one of the ways we want to be able to accept translations for and we are still figuring out the workflow, but if you are interested in adding translations, please let me know and I'll give you access to Transifex 🙏 🙏 . Approving this since it is a valid addition and useful data, but I will not merge it since it will just be overwritten when we pull data from Transifex.

@Angamanga
Copy link
Contributor

@Angamanga Translations for Transifex.

@kivuvarosekivuvan
Copy link
Contributor Author

@Angamanga Thank you the approval 🙏. I am very excited 🙂 to work on this because it presents a crucial area for improvement / accessibility in the platform and learning. Kindly add me to Transifex

@Angamanga Angamanga closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants