[Outreachy Task Submission] Fix Missing Search Button Value Text #902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
The search form component in both the
Data
andMap
view has a problem. The search button has only an icon and has no value text. While this is just a stylistic choice, it raises an issue with any accessibility checking tool. It does this because a button having no value text is a violation of WCAG Success Criterion 1.1.1 (Level A) - Non-text content. See. See a screenshot of the pertinent component:How to Test the PR
Manually Testing
data
ormap
section.span
element with a class ofmzima-button__text
. See screenshot below:span
element this time around, and this text will be visually hidden.Using an Accessibility Checker
If you use a tool like WAVE evaluation tool, it's as simple as following steps 1 and 2 above, and then turning on the browser extension. It will flag the issue. Checkout to the PR and do this again, you will notice the issue is no longer flagged.
Dependency
It has a dependency on a previous PR
Fixes
It partially fixes #4805