-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outreachy Task Submission] Background and foreground colors do not have a sufficient contrast ratio on Post card #914
Conversation
text - increase contrast ratio for Post Info text on post card
text - increase contrast ratio for Post Info text on post card
…UNNY12/platform-client-mzima into card-sufficient-contrast-ratio
@Angamanga Please Kindly Review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! A small change is needed before approving 🙏
apps/web-mzima-client/src/env.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"production": true, | |||
"backend_url": "http://localhost:8080/", | |||
"backend_url": "https://outreachyushahidi.api.ushahidi.io/", | |||
"api_v3": "api/v3/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the localhost:8080 url here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the localhost:8080 url here
Thank you @Angamanga for the review. I have make the necessary changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good day @Angamanga, This is a reminder to kindly review this changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Approved 🎉
Thank you @Angamanga . Its my honor to be part of this community |
Description
This PR addresses the accessibility issue I identified in Issue #4842, where the background and foreground colors on the Post card did not have a sufficient contrast ratio. The lack of contrast made it difficult for some users, particularly those with visual impairments, to read the content on the card.
Solution
To resolve this issue, this PR adjusts the colors to ensure that the contrast ratio between the background and foreground meets the Web Content Accessibility Guidelines (WCAG) standards. By improving the color contrast, this change enhances the readability and usability of the Post card for all users.
Screen record after fix
my_backend_url.-.Google.Chrome.2024-03-18.14-42-27.mp4
Purpose
This PR is a part of my submission for the Outreachy task, and it contributes to improving the accessibility of the Ushahidi platform.