Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission] Background and foreground colors do not have a sufficient contrast ratio on Post card #914

Closed

Conversation

JUNNY12
Copy link

@JUNNY12 JUNNY12 commented Mar 18, 2024

Description

This PR addresses the accessibility issue I identified in Issue #4842, where the background and foreground colors on the Post card did not have a sufficient contrast ratio. The lack of contrast made it difficult for some users, particularly those with visual impairments, to read the content on the card.

Solution

To resolve this issue, this PR adjusts the colors to ensure that the contrast ratio between the background and foreground meets the Web Content Accessibility Guidelines (WCAG) standards. By improving the color contrast, this change enhances the readability and usability of the Post card for all users.

Screen record after fix

my_backend_url.-.Google.Chrome.2024-03-18.14-42-27.mp4

Purpose

This PR is a part of my submission for the Outreachy task, and it contributes to improving the accessibility of the Ushahidi platform.

@JUNNY12
Copy link
Author

JUNNY12 commented Mar 18, 2024

@Angamanga Please Kindly Review this

@Angamanga Angamanga self-requested a review March 20, 2024 19:02
Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! A small change is needed before approving 🙏

@@ -1,6 +1,6 @@
{
"production": true,
"backend_url": "http://localhost:8080/",
"backend_url": "https://outreachyushahidi.api.ushahidi.io/",
"api_v3": "api/v3/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the localhost:8080 url here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the localhost:8080 url here

Thank you @Angamanga for the review. I have make the necessary changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day @Angamanga, This is a reminder to kindly review this changes

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Approved 🎉

@JUNNY12
Copy link
Author

JUNNY12 commented Mar 29, 2024

Thank you! Approved 🎉

Thank you @Angamanga . Its my honor to be part of this community

@Angamanga Angamanga closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants