Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Task Submission ] The HTML-embedded icon for copying does not gain focus when navigating through tabs using the keyboard in the Share Deployment Modal. #989

Conversation

MugoBrian
Copy link
Contributor

This PR addresses this issue.

Fix:
The HTML-embedded icon for copying is now reachable via keyboard tab navigation, enabling users to execute the "copy code" action using keyboard input.

  1. The HTML-embedded icon is now focusable.
  2. Users can now copy the code using the Enter key on the keyboard.
  3. Margin bottom has been included for both the "share on Twitter" and "share on Facebook" buttons.

Steps To Reproduce The Fix:
See the screencast below for reference:

Go to the Ushahidi client platform.

  1. Click the Share button, and a modal will pop up.
  2. Navigate the Share deployment modal using the Tab button to traverse the elements.
  3. You will notice the copy icon receives tab focus.
  4. Click enter to copy the code. Expected results: The HTML code to be copied.

Environment:
Browser: Chrome & Firefox

Screencast.from.30-03-2024.05.32.08.ALASIRI.webm

@MugoBrian
Copy link
Contributor Author

Hello @Angamanga and @Ifycode. This PR is ready for review.

@Angamanga Angamanga closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants