Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce linkchecker spam #1916

Conversation

nikitawootten-nist
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist commented Sep 6, 2023

Committer Notes

Fixes #1348

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@nikitawootten-nist nikitawootten-nist changed the title [DRAFT] Test linkchecker behavior [DRAFT] Reduce linkchecker spam Sep 6, 2023
@nikitawootten-nist nikitawootten-nist force-pushed the nikitawootten-nist/issue1348 branch 5 times, most recently from 7f8146a to b9de254 Compare September 6, 2023 18:37
@nikitawootten-nist nikitawootten-nist force-pushed the nikitawootten-nist/issue1348 branch from b9de254 to 6e8499d Compare September 6, 2023 18:40
@nikitawootten-nist nikitawootten-nist changed the title [DRAFT] Reduce linkchecker spam Reduce linkchecker spam Sep 6, 2023
@nikitawootten-nist
Copy link
Contributor Author

See nikitawootten-nist#2 for an example output

@aj-stein-nist aj-stein-nist self-requested a review September 6, 2023 19:45
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I paired with Nikita and worked with him to test it, so I approve.

@nikitawootten-nist nikitawootten-nist linked an issue Sep 6, 2023 that may be closed by this pull request
3 tasks
@aj-stein-nist aj-stein-nist merged commit b769ce4 into usnistgov:develop Sep 11, 2023
aj-stein-nist pushed a commit that referenced this pull request Sep 12, 2023
* Test linkchecker behavior

* Add permissions to linkchecker

* Removed test link failure

* Tidy up extraneous comment
Arminta-Jenkins-NIST pushed a commit that referenced this pull request Sep 12, 2023
* Test linkchecker behavior

* Add permissions to linkchecker

* Removed test link failure

* Tidy up extraneous comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduled Link Checks Check History to Limit False Positives
2 participants