Fix file naming on Safari downloads #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayPlante
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses and resolves an issue encountered in the Safari browser, where downloaded files were named "download" regardless of their intended filenames. The root cause was the absence of the "attachment" keyword in the Content-Disposition header. Prefixing the filename in the Content-Disposition header with "attachment" ensures that the specified filename overrides the download attribute content in Safari. In Chrome and Firefox, the filename specified in the Content-Disposition header takes precedence and is used for the downloaded file, regardless of the presence or absence of the "download" attribute in the anchor tag.
Testing using oar-docker was done across all three browsers: Safari, Chrome, and Firefox. The tests confirmed that files are now downloaded using the names specified in the Content-Disposition header.