Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile typo causing request to install python2 #109

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

RayPlante
Copy link
Collaborator

@RayPlante RayPlante commented Aug 21, 2024

The Dockerfile for the docker/build-test container--used to build the distribution service jar--contained what appeared to be a cut-and-paste error that was resulting in an attempt to install the deprecated python2. This PR pulls the errant lines from the Dockerfile.

To test, please build via oar-docker, branch=test/chips-coll-sdp, and localdeploy. If the distservice container builds successfully, you can approve this PR.

Copy link
Contributor

@elmiomar elmiomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is successful when using branch fix/docker-build-typo for the distservice is deployment.yml file.

@chuanlin2018
Copy link
Contributor

I got following error this time:

#########################

Building auth-py...

#########################

  • scripts/install.sh --install-dir=/dev/oar-auth-py/python/dist/oarauth
    Installing into /dev/oar-auth-py/python/dist/oarauth...

Installing python libraries into /dev/oar-auth-py/python/dist/oarauth/lib/python...
Traceback (most recent call last):
File "setup.py", line 2, in
from setuptools import setup, find_namespace_packages
ModuleNotFoundError: No module named 'setuptools'
localbuild: oar-auth-py: build failure: Failed to build components from oar-auth-py
localbuild: The following components failed to build:
localbuild: oar-auth-py: build failure: Failed to build components from oar-auth-py
localbuild: Some components not available due to build failures
localdeploy: One or more needed components failed to build

@elmiomar
Copy link
Contributor

  • scripts/install.sh --install-dir=/dev/oar-auth-py/python/dist/oarauth
    Installing into /dev/oar-auth-py/python/dist/oarauth...

ModuleNotFoundError: No module named 'setuptools'

Can you try installing setuptools? @chuanlin2018

@chuanlin2018
Copy link
Contributor

I installed "setuptools" following this instruction:
https://www.geeksforgeeks.org/how-to-set-up-setuptools-for-python-on-macos/
But it still complained "No module named 'setuptools'".

I decided to manually build individual app. For ../scripts/localdeploy -f ingestdata, both my old and new machine got this error:

#8 1.849 Get:19 http://archive.ubuntu.com/ubuntu focal-backports/main amd64 Packages [55.2 kB]
#8 1.855 Get:20 http://archive.ubuntu.com/ubuntu focal-backports/universe amd64 Packages [28.6 kB]
#8 1.904 Get:21 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages [3933 kB]
#8 3.487 Reading package lists...
#8 5.100 W: GPG error: http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 Release: The following signatures were invalid: EXPKEYSIG 656408E390CFB1F5 MongoDB 4.4 Release Signing Key [email protected]
#8 5.100 E: The repository 'http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 Release' is not signed.
#8 ERROR: process "/bin/sh -c apt-get update && apt-get install -y ca-certificates locales python3.8 python3-pip python3.8-dev" did not complete successfully: exit code: 100

@chuanlin2018
Copy link
Contributor

../scripts/localdeploy -f ingestservice got the same error:

#8 2.869 Get:21 http://archive.ubuntu.com/ubuntu focal-backports/universe amd64 Packages [28.6 kB]
#8 3.946 Reading package lists...
#8 5.396 W: GPG error: http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 Release: The following signatures were invalid: EXPKEYSIG 656408E390CFB1F5 MongoDB 4.4 Release Signing Key [email protected]
#8 5.396 E: The repository 'http://repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 Release' is not signed.
#8 ERROR: process "/bin/sh -c apt-get update && apt-get install -y ca-certificates locales python3.8 python3-pip python3.8-dev" did not complete successfully: exit code: 100

@elmiomar
Copy link
Contributor

This issue was investigated previously in oar-metadata PR#62, and Ray fixed it by upgrading to Ubuntu 22 and MongoDB 7 in PR#63.

Maybe use a recent branch for oar-metadata/ingestservice component? @chuanlin2018 @RayPlante

@RayPlante
Copy link
Collaborator Author

This PR is supposed to be specifically about building oar-dist-service under oar-docker. I'm going to take Omar's success as approval.

@RayPlante RayPlante merged commit 459500f into integration Sep 2, 2024
2 checks passed
@RayPlante RayPlante deleted the fix/docker-build-typo branch September 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants