Fix/odd770 filepath 771 missing item #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayPlante
approved these changes
May 20, 2019
There was a problem hiding this comment.
Tested this under oar-docker. I have confirmed:
- When a data cart download request includes some bad files, the path to the file will be shown in the error section.
- When adding all files from a resource containing multiple hierarchical folders, the full contents of all folders are included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODD770: http://mml.nist.gov:8080/browse/ODD-770
Now display file path in the warning message of bundle download.
ODD771: http://mml.nist.gov:8080/browse/ODD-771
Now use full path instead of file name as resID to avoid duplication.