Added benchmarking capabilities for the mongodb benchmark #23
Conversation
| @dataclass(frozen=True) | ||
| class BenchmarkConfig(ConfigBase): | ||
|
|
||
| recordCount: int = 1000000 |
There was a problem hiding this comment.
please use lower snake case instead of camel case, i.e. record_count
note: Pascal case is fine for class names as you have done
There was a problem hiding this comment.
Also, after you make the above fix, please run make defaults to generate a new defaults.yaml and then commit those changes
There was a problem hiding this comment.
Also, it does not look like you use these configuration options at all anywhere
Please use them to configure the mongodb benchmark
| @@ -0,0 +1,182 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # GAPBS Benchmark Runner | |||
There was a problem hiding this comment.
where did you get this file, or did you write it yourself?
| trap cleanup INT | ||
|
|
||
| # Run main function | ||
| main |
There was a problem hiding this comment.
it looks like you have not installed any pre-commit hooks,
please run make hooks and then make pre-commit, fixing any issues that appear -- although that command will fix some of the simpler ones like adding a newline at the end of every file, in those cases simply do git add . && make pre-commit
| @@ -0,0 +1,370 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
also, none of these scripts, if they are kept, should be in the top-level directory of this repo, please move them to a sane place under scripts for now, like scripts/run-benchmarks/*
|
Please also run |
|
We should probably meet sometime early next week to discuss what all of these scripts do and why they are needed in the codebase |
Run