Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Lock (Mutex) implementation and test #11

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Simple Lock (Mutex) implementation and test #11

merged 3 commits into from
Apr 4, 2024

Conversation

ywwu928
Copy link
Contributor

@ywwu928 ywwu928 commented Apr 3, 2024

Description

Important -- Read Before Creating a Pull Request

PR description

This PR write a high-level description of your pull request

Checklist

  • [v] The additions follow the code standards in the developer guide.
  • [v] New or existing tests cover these changes.
  • [v] The documentation is up to date with these changes.

@AdityaAtulTewari AdityaAtulTewari force-pushed the ywwu/simple_lock branch 2 times, most recently from 93ae3d3 to b514ce8 Compare April 4, 2024 07:29
AdityaAtulTewari
AdityaAtulTewari requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@AdityaAtulTewari AdityaAtulTewari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this one thing then it can be approved.

test/sync/test_simple_lock.cpp Outdated Show resolved Hide resolved
AdityaAtulTewari
AdityaAtulTewari approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@AdityaAtulTewari AdityaAtulTewari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait till ci passes to squash merge.

@ywwu928 ywwu928 merged commit bb489c8 into main Apr 4, 2024
4 checks passed
@ywwu928 ywwu928 deleted the ywwu/simple_lock branch April 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaAtulTewari AdityaAtulTewari AdityaAtulTewari approved these changes

@patrickkenney9801 patrickkenney9801 Awaiting requested review from patrickkenney9801

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ywwu928 @AdityaAtulTewari