Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDLCSR construct (fixed Jeageun's bug) #17

Closed
wants to merge 28 commits into from
Closed

Conversation

ywwu928
Copy link
Contributor

@ywwu928 ywwu928 commented Apr 4, 2024

Description

Important -- Read Before Creating a Pull Request

PR description

This PR write a high-level description of your pull request

Checklist

  • [v] The additions follow the code standards in the developer guide.
  • [v] New or existing tests cover these changes.
  • [v] The documentation is up to date with these changes.

jeageun and others added 2 commits April 4, 2024 10:25
* Implementation for mirrored local dist CSR

* Add decent test to cover all implemented construction functions and pass the test.
@jeageun
Copy link
Contributor

jeageun commented Apr 4, 2024

It seems like the test timeout was the problem. I tried to improve test performance by adding early exit. However, if it doesn't work, we could remove some heavy test cases.

@AdityaAtulTewari
Copy link
Contributor

the issue is the tests for 1024 vertices should not be expensive

@jeageun
Copy link
Contributor

jeageun commented Apr 4, 2024

I will try to speed up this test. Each test cycle doesn't take that long, however, it has too many loops to go through right now. I will handle this.

jeageun and others added 23 commits April 4, 2024 16:48
This reverts commit ddb2aa3.
* Stash things

* Added HostLocalArray

* Almost there

* Assign almost done

* It compiles

* Finally all testing ready

* These tests were using fmap wrong

* Fixed further test errors

* Fixed a few more test errors
* Refactor test to be faster

* Thread Local Storage test was too expensive
* shorten vector tests

* Make builds easier to access

* Small fix

* Workflows updated to be cleaner

* Reduce test sizes further

* Try using cpusets

* Try using labels to determine cpusets

* Try using names to determine cpusets

* Forgot the coverage type
* Fix simplelock test

* Refactor the reading of vertices for partitioning
@jeageun
Copy link
Contributor

jeageun commented Apr 6, 2024

@AdityaAtulTewari Now, it passes all test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be conflict with #28

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

@@ -18,7 +18,7 @@ namespace galois {

namespace HostLocalStorageHeap {

constexpr std::uint64_t Size = 1 << 10;
constexpr std::uint64_t Size = 1 << 20;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this modification, there is error on HeapLocalStorage init.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is not my change, it is from rebase.

@jeageun
Copy link
Contributor

jeageun commented Apr 6, 2024

Since it is too large, will make new push request.

@jeageun jeageun closed this Apr 6, 2024
@ywwu928 ywwu928 deleted the ywwu/MDLCSR_construct branch April 9, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants