-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDLCSR construct (fixed Jeageun's bug) #17
Conversation
* Implementation for mirrored local dist CSR * Add decent test to cover all implemented construction functions and pass the test.
It seems like the test timeout was the problem. I tried to improve test performance by adding early exit. However, if it doesn't work, we could remove some heavy test cases. |
the issue is the tests for 1024 vertices should not be expensive |
I will try to speed up this test. Each test cycle doesn't take that long, however, it has too many loops to go through right now. I will handle this. |
… that he don't use it
This reverts commit ddb2aa3.
This reverts commit 03ce181.
* Stash things * Added HostLocalArray * Almost there * Assign almost done * It compiles * Finally all testing ready * These tests were using fmap wrong * Fixed further test errors * Fixed a few more test errors
* Refactor test to be faster * Thread Local Storage test was too expensive
* shorten vector tests * Make builds easier to access * Small fix * Workflows updated to be cleaner * Reduce test sizes further * Try using cpusets * Try using labels to determine cpusets * Try using names to determine cpusets * Forgot the coverage type
* Fix simplelock test * Refactor the reading of vertices for partitioning
@AdityaAtulTewari Now, it passes all test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be conflict with #28
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
@@ -18,7 +18,7 @@ namespace galois { | |||
|
|||
namespace HostLocalStorageHeap { | |||
|
|||
constexpr std::uint64_t Size = 1 << 10; | |||
constexpr std::uint64_t Size = 1 << 20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this modification, there is error on HeapLocalStorage init.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is not my change, it is from rebase.
Since it is too large, will make new push request. |
Description
Important -- Read Before Creating a Pull Request
PR description
This PR write a high-level description of your pull request
Checklist