DENA-969: Split tflint configs between MSK and team clusters #573
Conversation
sbuliarca
changed the title
| @@ -10,5 +12,5 @@ rule "terraform_standard_module_structure" { | |||
|
|
|||
| # Include module calls | |||
| config { | |||
| module = true | |||
| call_module_type = "all" | |||
There was a problem hiding this comment.
Makes sense terraform-linters/tflint#1918
| # use compact, so that errors will be reported by the GH action see https://github.com/terraform-linters/setup-tflint?tab=readme-ov-file#checks | ||
| - --args=--format=compact | ||
| # We won't be able to use --hook-config=--delegate-chdir, as we need to determine the current folder in our plugin tflint-ruleset-kafka-config. | ||
| files: "^.*/kafka-shared-msk/.+/.*$" |
There was a problem hiding this comment.
To keep things simple, we could probably just match the start of the path (or is there a reason we enforce the depth with the /.+/. bit?)
| files: "^.*/kafka-shared-msk/.+/.*$" | |
| files: "^.*/kafka-shared-msk/" |
There was a problem hiding this comment.
Yea, as we don't wanna run it on the folder dev-asw/kafka-shared-msk/ as it doesn't contain any module. Only on its subfolders
| module = true | ||
| call_module_type = "all" |
There was a problem hiding this comment.
this seems to require tflint v0.50.0+ https://github.com/terraform-linters/tflint/releases/tag/v0.50.0 but I don't think we version this at all (it needs to be installed independently from pre-commit, maybe worth noting somewhere that we only support running the latest version of tflint
There was a problem hiding this comment.
We mention installing it here: https://github.com/utilitywarehouse/kafka-cluster-config/blob/main/CONTRIBUTING.md. Maybe worth moving it directly to readme, as it might be missed
We need to split this, as we want to implement rules that apply only for MSK modules