Position_Controlled_Motors and friends #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amessing
reviewed
Apr 26, 2017
| from .component import Component | ||
|
|
||
|
|
||
| class Pid(Component): |
There was a problem hiding this comment.
Shouldn't this class be Vpid and all the functions only be for vpid?
There was a problem hiding this comment.
It should, that class also still needs to be cut down to just vpid. I'm doing it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes...
Seperated pid and vpid.
Added position_controlled_motor.
Fixed i2c_encoder raw_position and get_position.
Added some debugging to core for commands not implemented.
I made a couple more local changes that need to be pushed before merging.