Bugfix for max reduction + visibility for Spectrum

utk-team · Nov 9, 2023 · 7f178d7 · 7f178d7
1 parent 9b36d6a
commit 7f178d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/include/utk/utils/Omp.hpp b/include/utk/utils/Omp.hpp
@@ -47,7 +47,7 @@
     template<typename T>
     T omp_parallel_max(const T* data, uint32_t size)
     {
-        T max_val = std::numeric_limits<T>::max();
+        T max_val = std::numeric_limits<T>::min();
 
         #pragma omp parallel
         {
@@ -74,7 +74,7 @@
     template<typename T>
     T omp_parallel_max(const T* data, uint32_t size)
     {
-        T maxval = std::numeric_limits<T>::max();
+        T maxval = std::numeric_limits<T>::min();
 
         #pragma omp parallel for reduction(max: maxval)
         for (OPENMP_UINT i = 0; i < size; i++)

diff --git a/src/metrics/Spectrum.cpp b/src/metrics/Spectrum.cpp
@@ -77,7 +77,7 @@ int main(int argc, char** argv)
         }
 
         unsigned char* data = new unsigned char[res * res];    
-        double maxval = omp_parallel_max(rslts.data(), rslts.size());
+        const double maxval = omp_parallel_max(rslts.data(), rslts.size());
 
         // Copy data to unsigned char buffer
         #pragma omp parallel for
@@ -87,7 +87,8 @@ int main(int argc, char** argv)
             {
                 const OPENMP_UINT idx = x + y * res;
 
-                double value = rslts[idx] / maxval;
+                // Common scaling to enhance visibility
+                double value = std::sqrt(rslts[idx] / maxval);
                 data[idx] = static_cast<unsigned char>(255 * value);
             }
         }