-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should github-dark theme match official Github Dark mode? #462
Comments
For sure, just waiting on the next primer update |
Is this something that will be automatically updated (e.g. Primer provides it) or will the color codes need to be changed here? I ask because I'm testing locally and modified the github-dark theme to match the current Github Dark Mode. I can submit a PR if you want either as a separate theme or updated github-dark. Thanks! |
Utterances uses standard primer for the GitHub light theme, then a modified primer for the rest of the themes, including GitHub dark. Mostly variable changes. Once GitHub ships a new version of primer with all the css custom property and dark theme work, I’ll update utterances to use it. |
Hello!
I was curious to get your thouts on the "github-dark" theme. Currently it doesn't match the official GitHub Dark mode colors.
Do you think the "github-dark" them should be updated or a new them added?
Thank you!
The text was updated successfully, but these errors were encountered: