Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new theme classic-dark #463

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

rpetit3
Copy link

@rpetit3 rpetit3 commented Jan 8, 2021

Hello!

Here's a new theme that is based off 'github-dark' to match Github's current Dark Mode.

We had a brief discussion (#462) and I realize the "github-dark" theme will be updated when Primer is updated. This made me think it might be useful to create a separate theme, so that changes to Primer or GitHub's Dark Mode won't affect the theme.

I named it dark-mood, and I'm not attached to it, so if you want to rename go for it!

Please let me know if anything else is needed.

Thank you!

Here's a screenshots, from my local build:
dark-mood
dark-mood2

@jdanyow
Copy link
Member

jdanyow commented Feb 17, 2021

@rpetit3 I like the idea of keeping the original dark theme around for folks who don't want to adopt GitHub's official dark theme. I'll revisit this PR once Primer lands primer/css#1131.

What do you think of Classic Dark for the theme name?

@rpetit3
Copy link
Author

rpetit3 commented Feb 17, 2021

Classic Dark works perfectly! I'll update the PR

@rpetit3 rpetit3 changed the title add new theme dark mood add new theme classic-dark Feb 23, 2021
Copy link
Contributor

@zsdycs zsdycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdanyow

I think this "PR" can be merged.
It has been included in the Chinese version Beaudar.

@rpetit3
Copy link
Author

rpetit3 commented Jun 26, 2021

Hi @jdanyow

If you have a moment, would love to get your thoughts.

Thank you!

@rpetit3
Copy link
Author

rpetit3 commented Aug 18, 2021

@jdanyow - Please me know if anything is needed on my end.

@rpetit3
Copy link
Author

rpetit3 commented Oct 7, 2021

@jdanyow I think I'm going to go ahead and abandon this PR.

Utterances is great cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants