Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic page size [non-breaking change] #375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

WeixuanZ
Copy link

@WeixuanZ WeixuanZ commented Aug 3, 2020

Related to #344. Added size optional argument, equaling 25 if not specified so existing users will not notice any difference. This addresses the issue of extra-long comment sections, causing scrolling difficulties.

If the specified size is less than 16, the hidden-page size will increase exponentially until 16 is reached, avoiding problems with rate limiting.

If the specified size is larger or equal to 16, the hidden-page size will be equal to the specified size. E.g. if no size argument is passed in, the hidden-page size will default to a constant of 25, which is the same as before.

As the page size is now dynamic, logic to include penultimate page was also modified to be less than half of the given page size.

Setting size=1:
1

Added size optional argument, equaling 25 if not specified so old users will not see any difference. This addresses the issue of extra-long comment sections, causing scrolling difficulties.

If the specified size is less than 16, the hidden-page size will increase exponentially until 16 is reached, avoiding problems with rate limiting.

If the specified size is larger or equal to 16, the hidden-page size will be equal to the specified size. E.g. if no size argument is passed in, the hidden-page size will default to 25, which is the same as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant