-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for floating-point arithmetic added #6
base: master
Are you sure you want to change the base?
Conversation
…ionals as an ITerm
…k, tests should be added to both
Presentation
Presentation
.attach_pid35637
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be some empty files added by mistake.
acsl-parser/acsl.cf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please call make
on the ACSL parser and commit the new jar file as well (that's not built as part of the build process).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empty file.
def isNeginf(t: ITerm): IFormula = longDoubleADT.hasCtor(t, 3) | ||
} | ||
|
||
object LongDoubles { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should avoid making CCReader longer than it already is :-) The new classes/objects you add can be in a new file.
import CCReader._ | ||
import ccreader._ | ||
import tricera.params.TriCeraParameters | ||
import tricera.concurrency.CCReader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file seem unnecessary.
@dannem1337 Thank you for creating this PR! I added some quick comments , would be nice if you could address them! It would also be helpful to provide a more detailed PR description. |
Hello, |
This PR adds basic support for Float, Double and Long Double using the theory of rationals.
What has been added:
What is missing: