Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 1st party cookies #5

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Use 1st party cookies #5

merged 2 commits into from
Jan 23, 2024

Conversation

ivan-c
Copy link
Member

@ivan-c ivan-c commented Dec 21, 2023 •
edited
Loading

  • Set cookie domain to base domain of deploy
  • Remove 3rd party cookie attribute

See

@ivan-c ivan-c mentioned this pull request Dec 21, 2023
Merged
@ivan-c ivan-c marked this pull request as ready for review December 21, 2023 19:14
@ivan-c ivan-c requested a review from pbugni December 21, 2023 19:16
pbugni
pbugni approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivan-c ivan-c merged commit 18f8349 into main Jan 23, 2024
@ivan-c ivan-c deleted the fixup/cookie-domain branch January 23, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbugni pbugni pbugni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivan-c @pbugni