Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration to remove Zulu locale. #4353

Merged
merged 2 commits into from
Dec 6, 2023
Merged

migration to remove Zulu locale. #4353

merged 2 commits into from
Dec 6, 2023

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Dec 5, 2023

Migration for PR #4349

@pep8speaks
Copy link

pep8speaks commented Dec 5, 2023 •
edited
Loading

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 21:80: E501 line too long (87 > 79 characters)
Line 23:80: E501 line too long (87 > 79 characters)
Line 34:80: E501 line too long (106 > 79 characters)

Comment last updated at 2023-12-05 23:55:31 UTC

@pbugni pbugni requested review from mcjustin and ivan-c December 5, 2023 23:38
ivan-c
ivan-c approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but think there may be issues with the JSON files vs DB

portal/migrations/versions/d1f3ed8d16ef_.py Show resolved Hide resolved
@pbugni pbugni merged commit e53c159 into develop Dec 6, 2023
1 check passed
@pbugni pbugni deleted the feature/migration-from-zulu branch December 6, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcjustin mcjustin mcjustin approved these changes

@ivan-c ivan-c ivan-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbugni @pep8speaks @mcjustin @ivan-c