Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ban command input #528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve ban command input #528

wants to merge 1 commit into from

Conversation

hyper-neutrino
Copy link
Contributor

Summary of Changes

  • currently, the ban command only allows inputting a number of days for purging on ban, which is outdated as full second-by-second granularity is now supporter
  • additionally, the ban command will currently experience an internal error if the duration provided exceeds the maximum allowance of 7 days instead of offering a descriptive error message
  • this change allows inputting any duration and provides a meaningful error message

Steps to Reproduce

  • use the ban command

Demonstration of Changes

image
image

@hyper-neutrino hyper-neutrino mentioned this pull request Jul 14, 2024
Open
@davidgan1218 davidgan1218 requested review from davidgan1218 and removed request for Fan-Yang-284 and probro27 September 28, 2024 00:15
@davidgan1218
Copy link
Contributor

maybe we should add option to specify ban duration as well as message purging duration.

@KuroganeToyama KuroganeToyama linked an issue Sep 28, 2024 that may be closed by this pull request
Improve ban command purge duration behavior #520
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgan1218 davidgan1218 Awaiting requested review from davidgan1218 davidgan1218 is a code owner

@KuroganeToyama KuroganeToyama Awaiting requested review from KuroganeToyama KuroganeToyama is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve ban command purge duration behavior
2 participants
@hyper-neutrino @davidgan1218