Major fix: Filtering on events by shifts now works. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent pages. Index.html: Filtering on events by shifts is now fixed and working. _details changes: html safe on a no break.
| </div> | ||
|
|
||
| <script type="text/javascript"> | ||
|
|
||
| function filterEvents() { |
There was a problem hiding this comment.
Is this necessary, or could it be deleted?
There was a problem hiding this comment.
I think this can be deleted. I didnt even see this empty stub... I will delete this asap
| var emailsAttending = []; | ||
| attending_rows.each(function(key, value) { | ||
| emailsAttending.push(value.getAttribute('data-email')); | ||
| }); |
There was a problem hiding this comment.
For these 4 lines, you might consider jQuery's map function with a .get().join(",") like in the example code on that page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three files were updated. Details as follows.
Index.html: Filtering on events by shifts is now fixed and working.
CSS changes: minor, so that participant number shows up aligned on event pages. [Minor]
_details changes: html safe on a no break. [Minor]