Software Challenge Urban Pistek #11

UrbanPistek · 2020-11-04T02:13:33Z

Hello here is my code for the software challenge, let me know what you think, thanks!

Made small chnages to main and resetTurtle

software_training_assignment/CMakeLists.txt

software_training_assignment/package.xml

software_training_assignment/src/main.cpp

software_training_assignment/src/resetTurtle.cpp

software_training_assignment/src/moveTurtle.cpp

azumnanji · 2020-11-13T01:16:02Z

software_training_assignment/src/main.cpp

-    } else {
-        ROS_INFO("Action Failed");
+    //Infinite loop to run
+    while(true){


if you look at the tutorials we want all loops to kill if the ros master is killed so we usually use while (ros::ok())

azumnanji · 2020-11-13T01:18:02Z

software_training_assignment/src/main.cpp

+            ROS_INFO("Action Finished");
+        } else {
+            ROS_INFO("Action Failed");
+        }


you're missing the ros::spinOnce function, this is the function that checks for new msgs, service calls, actions and other. its what lets us communicate between many applications running ros

azumnanji · 2020-11-13T01:21:09Z

software_training_assignment/src/moveTurtle.cpp

-int main(int argc, char **argv) {
-    ros::init(argc, argv, "moveTurtle"); 
-    ros::NodeHandle nh; 
+        MoveTurtleAction(std::string name) : 


copy nodehandle to class nodehandle

Do you mean to put nodehandle in its own class?
Currently nodehandle is in the MoveTurtleActionClass:
class MoveTurtleAction { protected: ros::NodeHandle nh;

UrbanPistek and others added 8 commits August 17, 2020 00:06

Launch file created, service clients added

f5e0cf9

Added Custom reset turtle service

4b71dcd

Added clear turtles service

aabc1c4

Custom msg publisher added

249c968

Added action client, need to add action server

7a5507a

Adding action implmentation

ba63d7b

Made small chnages to main and resetTurtle

17ce177

Merge pull request #1 from UrbanPistek/urban_updates

6fb4cc4

Made small chnages to main and resetTurtle