-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DAAL examples build failures with C++20 #3072
Conversation
@Vika-F If I understand it correctly, the logic for checking that it works is that all examples compile successfully with C++20. But do examples cover all of the public headers that are offered by oneDAL? Could there perhaps be other files out there that need modifications? Would oneDAL compile under C++20 if you try it? (might also require modifications in internal headers, but could give some pointers as to whether the public headers have sufficient modifications or not). Also, I think in addition to the C++20 flag, for testing purposes you'd also have to add the flag |
|
Curious that it results in errors when trying to deduce templates with GCC:
|
@david-cortes-intel |
/intelci: run |
Do we do any regular validation on C++20 or how was this discovered? |
@ethanglaser It was discovered during oneAPI release validation. The examples were built with new GCC that enables C++20 by default. |
/intelci: run |
Remove templates ids in constructors to fix
error: template-id not allowed for constructor in C++20
.PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
Not applicable.