Update to use dockers built for OCK #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/switch_to_llvm_docker
branch
29 times, most recently
from
ef0acad to
a2304ce
Compare
coldav
force-pushed
the
colin/switch_to_llvm_docker
branch
9 times, most recently
from
19701da to
5c90db2
Compare
coldav
changed the title
coldav
force-pushed
the
colin/switch_to_llvm_docker
branch
from
5c90db2 to
623634f
Compare
We need to use a host of different machines, so for consistency we want to use a docker. This will also allow us to add more in it and do less installing of packages in the workflow.
coldav
force-pushed
the
colin/switch_to_llvm_docker
branch
from
623634f to
c2a0d8a
Compare
alan-forbes-cp
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update to use dockers built for OCK
Reason for change
Using different runners is causing issues with not always using the same dockers. This also allows us to move more setup into the dockers.
Description of change
Added container:/image: to most jobs
Anything else we should know?
Note run_clang_tidy_changes is currently disabled until we can resolve the errors brought up