-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the docs for helm #3395
Merged
Merged
Adjust the docs for helm #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaannz
approved these changes
Oct 25, 2024
keichwa
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic proposals.
modules/installation-and-upgrade/pages/container-deployment/suma/proxy-k3s-deployment-suma.adoc
Outdated
Show resolved
Hide resolved
modules/installation-and-upgrade/pages/container-deployment/suma/proxy-k3s-deployment-suma.adoc
Outdated
Show resolved
Hide resolved
...es/installation-and-upgrade/pages/container-deployment/uyuni/proxy-k3s-deployment-uyuni.adoc
Outdated
Show resolved
Hide resolved
...es/installation-and-upgrade/pages/container-deployment/uyuni/proxy-k3s-deployment-uyuni.adoc
Outdated
Show resolved
Hide resolved
I guess this PR also addresses #3323. |
…ma/proxy-k3s-deployment-suma.adoc Co-authored-by: Karl Eichwalder <[email protected]>
…ma/proxy-k3s-deployment-suma.adoc Co-authored-by: Karl Eichwalder <[email protected]>
…uni/proxy-k3s-deployment-uyuni.adoc Co-authored-by: Karl Eichwalder <[email protected]>
…uni/proxy-k3s-deployment-uyuni.adoc Co-authored-by: Karl Eichwalder <[email protected]>
jcayouette
approved these changes
Oct 28, 2024
Yes, this covers that. |
@jcayouette would it be feasible to port this to 5.0.2 MU as mentioned in description? |
0rnela
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are not shipping helm package anywhere so this PR add the guidelines to install from GitHub.
It also cleanup some conditional sections as those were not needed because we already have a separate page for Uyuni and SUSE Manager.
Last thing it does is to only include the relevant part of proxy config generation which doesn't contain anything about Podman.
Target branches
ifeval
statements are needed to publish it for certain products only.If feasible and not too late, please also include in 5.0.2. It's fine if this part doesn't get translated for now though.
Backport targets (edit as needed):
For backport tracking, see https://github.com/SUSE/spacewalk/issues/25462