Refactoring #17
Closed
Refactoring #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-garcia
commented
Aug 7, 2022
| ChalmetRecursion(m, yt_1, yt_2, ys_1, ys_2, varArray, rhs_z1, rhs_z2, ϵ, verbose ; kwargs...) | ||
| end | ||
|
|
||
| return nothing |
There was a problem hiding this comment.
Example of added return nothing
remi-garcia
commented
Aug 7, 2022
| # MIT License | ||
| # Copyright (c) 2017: Xavier Gandibleux, Anthony Przybylski, Gauthier Soleilhac, and contributors. | ||
|
|
||
| function solve_dicho(m::JuMP.Model; round_results::Bool=false, verbose, kwargs...) |
There was a problem hiding this comment.
round_results is a keyword argument here instead of an argument, same for verbose.
remi-garcia
commented
Aug 7, 2022
|
|
||
| if method in keys(methods) | ||
| solve_function = methods[method] | ||
| solve_function(m; verbose=verbose, relaxation=relax, kwargs...) |
There was a problem hiding this comment.
step and round_result are passed through kwargs, so dispatch is not necessary anymore. This permits to reduce the "cost" of adding new methods by just extending the Dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
return nothingwhen no return statement was provided;verbose,step,round_resultsas keyword arguments in order to avoid having to sort the arguments in thevSolvefunction;vSolve, replace the if/elseif conditions by a dict to functions.Tests pass locally, with JuMP 0.23 and 1.1.1 (this closes #16)