Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate getAttribute #1865

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: deprecate getAttribute #1865

merged 1 commit into from
Feb 7, 2025

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Feb 4, 2025

Fixes #1843

mcollovati
mcollovati approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and it seems not to break anything, at least in Flow tests.

@mcollovati mcollovati merged commit 18241db into main Feb 7, 2025
2 checks passed
@mcollovati mcollovati deleted the chore/deprecate-getAttribute branch February 7, 2025 09:00
@tepi tepi mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tepi @mcollovati