Close the overlay if size is 0 after data provider callback (#752)

vaadin · Dec 11, 2018 · 6a94726 · 6a94726
1 parent 8192d24
commit 6a94726
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/vaadin-combo-box-data-provider-mixin.html b/src/vaadin-combo-box-data-provider-mixin.html
@@ -150,6 +150,9 @@
             if (Object.keys(this._pendingRequests).length === 0) {
               this.loading = false;
             }
+            if (!this.size) {
+              this.opened = false;
+            }
           }
         };
         this._pendingRequests[page] = callback;

diff --git a/test/lazy-loading.html b/test/lazy-loading.html
@@ -111,6 +111,12 @@
             expect(comboBox.items).to.be.undefined;
           });
 
+          it('should close if empty result set is received', () => {
+            comboBox.dataProvider = (params, cb) => cb([], 0);
+            comboBox.opened = true;
+            expect(comboBox.opened).to.be.false;
+          });
+
           describe('when open', () => {
             beforeEach(() => comboBox.opened = true);