Update snapshot generator: group holidays by subdiv (#1578)

scripts/generate_snapshots.py

@@ -22,7 +22,7 @@
 sys.path.append(f"{Path.cwd()}")  # Make holidays visible.
 
 import holidays
-from holidays import HOLIDAY_NAME_DELIMITER, list_supported_countries, list_supported_financial
+from holidays import list_supported_countries, list_supported_financial
 
 
 class SnapshotGenerator:
@@ -62,15 +62,6 @@ def save(snapshot, file_path):
             )
             output.write("\n")  # Get along with pre-commit.
 
-    @staticmethod
-    def update_snapshot(snapshot, data):
-        for dt, name in data.items():
-            holiday_names = set(
-                snapshot[dt].split(HOLIDAY_NAME_DELIMITER) if dt in snapshot else ()
-            )
-            holiday_names.update(name.split(HOLIDAY_NAME_DELIMITER))
-            snapshot[dt] = HOLIDAY_NAME_DELIMITER.join(sorted(holiday_names))
-
     def generate_country_snapshots(self):
         """Generates country snapshots."""
         if len(self.args.market) > 0:
@@ -87,20 +78,18 @@ def generate_country_snapshots(self):
 
         for country_code in country_list:
             country = getattr(holidays, country_code)
-            snapshot = {}
 
             for subdiv in (None,) + country.subdivisions:
-                self.update_snapshot(
-                    snapshot,
+                self.save(
                     holidays.country_holidays(
                         country_code,
                         subdiv=subdiv,
                         years=self.years,
                         categories=country.supported_categories,
                         language="en_US",
                     ),
+                    f"snapshots/countries/{country_code}_{subdiv or 'COMMON'}.json",
                 )
-            self.save(snapshot, f"snapshots/countries/{country_code}.json")
 
     def generate_financial_snapshots(self):
         """Generates financial snapshots."""