Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING.rst #2264

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Fix typo in CONTRIBUTING.rst #2264

merged 1 commit into from
Feb 2, 2025

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Fix typo in CONTRIBUTING.rst.
Closes #2260.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

sonarqubecloud bot commented Feb 2, 2025

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (987ca01) to head (90e7f31).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2264   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          199       199           
  Lines        12134     12134           
  Branches      1731      1731           
=========================================
  Hits         12134     12134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Feb 2, 2025
Merged via the queue into vacanza:dev with commit f5475cb Feb 2, 2025
32 checks passed
@KJhellico KJhellico deleted the fix-docs branch February 2, 2025 21:11
@arkid15r arkid15r mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in documentation: “specific” should be “specify”
2 participants