Check .mo rather than .po files in TestListLocalizedEntities #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `.po` files are no longer included in distribution bundles (vacanza#2243), having this test look at `.po` files makes things slightly more difficult for downstream distributors such as Debian, since we run the tests on the equivalent of the built wheel.
cjwatson
requested review from
arkid15r,
KJhellico and
PPsyrius
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 199 199
Lines 12144 12144
Branches 1731 1731
=========================================
Hits 12144 12144 ☔ View full report in Codecov by Sentry. |
|
KJhellico
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Now that
.pofiles are no longer included in distribution bundles (#2243), having this test look at.pofiles makes things slightly more difficult for downstream distributors such as Debian, since we run the tests on the equivalent of the built wheel.Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green