Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct start date for 2x Historical South Africa holidays #2276

Closed
wants to merge 1 commit into from

Conversation

Firefishy
Copy link

Proposed change

South African historical holiday's improvements:

  • Union Day started in 1910, the year of the South African Union.
  • King's Birthday from 1910.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

* Union Day started in 1910, the year of the South African Union.
* King's Birthday from 1910.

Signed-off-by: Grant <[email protected]>
Copy link

sonarqubecloud bot commented Feb 8, 2025

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (47010d3) to head (5c5ecb2).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2276   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          200       200           
  Lines        12181     12181           
  Branches      1731      1731           
=========================================
  Hits         12181     12181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Feb 8, 2025

South Africa's holidays cut-off start date is already set as 1910 though so this might be redundant:

    # Observed since 1910, with a few name changes
    start_year = 1910

@Firefishy
Copy link
Author

As pointed out by @PPsyrius this PR is redundant :-)

@Firefishy Firefishy closed this Feb 8, 2025
@Firefishy Firefishy deleted the patch-1 branch February 8, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants