-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add make script for Windows #2277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2277 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 200 200
Lines 12181 12181
Branches 1731 1731
=========================================
Hits 12181 12181 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool 😎
I believe this should help resolve issue #956. |
|
I also hope it will help. Thank you for raising up this issue. |
Thank you for your response! Just to clarify, the issue was actually raised by @arkid15r . I was working on it as well, but before I had a chance to submit my pull request, I noticed yours and wanted to mention it. I appreciate your efforts on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of thoughts I have regarding this:
- do we need to update any docs? (I'm not sure how to use it on WIndows)
- while I regularly use
make
and can timely spot problems if any, there is no guarantee the same formake.cmd
. Should we add some sort of smoke tests for both mechanisms?
This script has been tested ny myself in real system, and I plan to use it in the future. But tests will be useful, for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed change
Add CMD script for Windows with
make
-like functionality.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green