Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make script for Windows #2277

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Add make script for Windows #2277

merged 2 commits into from
Feb 9, 2025

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Add CMD script for Windows with make-like functionality.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (47010d3) to head (389dc29).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2277   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          200       200           
  Lines        12181     12181           
  Branches      1731      1731           
=========================================
  Hits         12181     12181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool 😎

make.cmd Outdated Show resolved Hide resolved
make.cmd Outdated Show resolved Hide resolved
@Prateekshit73
Copy link
Contributor

I believe this should help resolve issue #956.

Copy link

sonarqubecloud bot commented Feb 9, 2025

@KJhellico
Copy link
Collaborator Author

I believe this should help resolve issue #956.

I also hope it will help. Thank you for raising up this issue.

@Prateekshit73
Copy link
Contributor

I also hope it will help. Thank you for raising up this issue.

Thank you for your response! Just to clarify, the issue was actually raised by @arkid15r . I was working on it as well, but before I had a chance to submit my pull request, I noticed yours and wanted to mention it. I appreciate your efforts on this!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts I have regarding this:

  • do we need to update any docs? (I'm not sure how to use it on WIndows)
  • while I regularly use make and can timely spot problems if any, there is no guarantee the same for make.cmd. Should we add some sort of smoke tests for both mechanisms?

@KJhellico
Copy link
Collaborator Author

This script has been tested ny myself in real system, and I plan to use it in the future. But tests will be useful, for sure.

@arkid15r arkid15r enabled auto-merge February 9, 2025 18:01
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arkid15r arkid15r added this pull request to the merge queue Feb 9, 2025
Merged via the queue into vacanza:dev with commit 7c88dc2 Feb 9, 2025
32 checks passed
@KJhellico KJhellico deleted the add-make-cmd branch February 9, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants