refactor(pubsub): do not raise exceptions on publish #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
NagyZoltanPeter
approved these changes
Feb 6, 2025
richard-ramos
force-pushed
the
refactor/publish-pubsub
branch
from
ea57994 to
7aef637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on #1243 (comment) the only scenario in which is it possible to have this exception being raised is due to a misconfig when initializing a message in
Since
Message.initis used only in these places and it's not expected for a consumer of nim-libp2p to create aMessagethemselves, adding this assertion is safe as it will immediatly indicate that the message is being initialized incorrectly.