Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: count with binning using multiple selections #2152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: count with binning using multiple selections #2152

wants to merge 1 commit into from

Conversation

JovanVeljanoski
Copy link
Member

Closes: #2151

  • Implement a test
  • test passes

@maartenbreddels
Copy link
Member

Ok, had to think about this, but I'm not sure what to do here.

a single aggregation will only be done on a 'fixed grid', so for both selections the same min and max. At some point, we started respecting the selection for the min and max of the binby grid, now I think this was a mistake, because we painted ourselves in a corner. We cannot have two different limits for the two different selections.

@maartenbreddels
Copy link
Member

@JovanVeljanoski we discussed this privately, do you remember what we decided?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maartenbreddels maartenbreddels

Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG-REPORT] df.count error with selections and no limits
2 participants
@JovanVeljanoski @maartenbreddels