Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix block_entities example #390

Merged
merged 2 commits into from
Jul 29, 2023
Merged

fix block_entities example #390

merged 2 commits into from
Jul 29, 2023

Conversation

dyc3
Copy link
Collaborator

@dyc3 dyc3 commented Jun 20, 2023 •
edited
Loading

Description

fixes #389

@Bafbi

This comment was marked as outdated.

Sign in to view
@dyc3
Copy link
Collaborator Author

dyc3 commented Jun 20, 2023 •
edited
Loading

Maybe it needs to have all 4 rows? Nope, that doesn't work.

@Bafbi
Copy link
Contributor

Bafbi commented Jun 20, 2023

and using to_string on text don't convert to json

@pepperoni21

This comment was marked as outdated.

Sign in to view
@dyc3 dyc3 marked this pull request as ready for review July 28, 2023 14:54
@dyc3
Copy link
Collaborator Author

dyc3 commented Jul 28, 2023 •
edited
Loading

I managed to figure it out. All 4 lines in messages are required, and they must all be rendered Text, even if blank.

I wasn't able to figure out how to import serde_json in the example though, so I had to add Text::render_json. nvm, figured it out.

@dyc3 dyc3 requested a review from rj00a July 28, 2023 15:35
@rj00a
Copy link
Member

rj00a commented Jul 29, 2023

Made some adjustments to Text. In particular, I removed the weird custom Debug/Display impl and just convert to JSON there.

Also enabled online mode in the example so that right clicking the skull functions correctly.

@rj00a rj00a merged commit 3af9472 into main Jul 29, 2023
13 checks passed
@rj00a rj00a deleted the fix-block-entities branch July 29, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rj00a rj00a Awaiting requested review from rj00a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix block_entities example
4 participants
@dyc3 @Bafbi @pepperoni21 @rj00a