Make bossbar use EntityLayer for visibility
#437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rj00a
reviewed
Aug 4, 2023
When a bossbar as a `Position` componant, the bossbar will only be shown when in view.
dyc3
requested changes
Aug 10, 2023
crates/valence_protocol/src/packets/play/update_selected_slot_c2s.rs
Outdated
Show resolved
Hide resolved
dyc3
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We want things to be easy for the user as possible, so I used the same api principes from EntityLayer.
Solution
BossBarBundlealso have anEntityLayerIdthat says in what layer they are, and client see bossbar that are in hisVisibleEntityLayers.