-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize Crates #449
Merged
Merged
Reorganize Crates #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Once again I am trying to reorganize the crate structure into something I'm happy with. Hopefully I got it right this time.
The goal is to make it easier to extend valence without an explosion of tiny crates or other problems. Also fixing miscellaneous issues along the way.
Solution
valence_client
withvalence_server
to accommodate a wider variety of modules.valence_server
is glob re-exported from the mainvalence
crate.valence_client
have become individual plugins for more flexibility.valence_server
andvalence_layer
since they were already tightly coupled. Removed lots of#[doc(hidden)]
as a result.valence_protocol
to contain all protocol related stuff. Replacesvalence_packet
andvalence_core
. This can be used by servers, clients, proxies, and other tools without dragging in valence-specific things.valence_generated
. Keeping this in one crate resolves some potential circular dependency issues between things like items and blocks.valence_protocol
depends on this so we can useBlockState
and other types in packets. It might slow down the build too much, so we could split it up if we have to.valence_math
. This re-exportsglam
+ our ownAabb
type which was previously invalence_core
.valence_biome
andvalence_dimension
intovalence_registry
.valence_text
andvalence_ident
respectively.valence_lang
to hold language related code like translation keys. There's not much there now, but it could be used for a registry of languages and translation keys in the future.TODO