Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place valence and bevy specific stuff in valence_anvil behind feature flags #510

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Place valence and bevy specific stuff in valence_anvil behind feature flags #510

merged 3 commits into from
Sep 1, 2023

Conversation

Earthcomputer
Copy link
Contributor

@Earthcomputer Earthcomputer commented Aug 31, 2023 •
edited
Loading

Objective

Solution

  • Place valence and bevy specific stuff in valence_anvil behind feature flags.
  • Support for entity and POI chunks can easily be added to DimensionFolder in the future.
  • Support for writing chunks is not included in this PR.

rj00a
rj00a reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@rj00a rj00a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

crates/valence_anvil/Cargo.toml Outdated Show resolved Hide resolved
crates/valence_anvil/Cargo.toml Outdated Show resolved Hide resolved
crates/valence_anvil/Cargo.toml Outdated Show resolved Hide resolved
crates/valence_anvil/Cargo.toml Outdated Show resolved Hide resolved
crates/valence_anvil/src/lib.rs Outdated Show resolved Hide resolved
@Earthcomputer
Copy link
Contributor Author

Looks like check-depgraph is failing to post a comment

@rj00a
Copy link
Member

rj00a commented Sep 1, 2023

Hmm yeah, I'll try fixing that separately.

@rj00a rj00a merged commit b3b2975 into valence-rs:main Sep 1, 2023
8 of 9 checks passed
@Earthcomputer Earthcomputer deleted the refactor_valence_anvil branch September 1, 2023 09:40
@Earthcomputer Earthcomputer mentioned this pull request Sep 1, 2023
Merged
rj00a pushed a commit that referenced this pull request Sep 3, 2023
@Earthcomputer
Add ability to write anvil chunks (#516)
78a12d4 
# Objective

- Follow on from #510 by adding the ability to write and delete chunks
in anvil files.

# Solution

- Users can change the compression method and whether to write oversized
chunks, in case they want to write anvil files compatible with older
versions of Minecraft.
- `LruCache::try_get_or_insert_mut` is something I have [pull
requested](jeromefroe/lru-rs#178) to `lru`, we
can switch to that once it's merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rj00a rj00a rj00a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change valence-anvil to be more general
2 participants
@Earthcomputer @rj00a