Go/jbrinkman randomize cluster ports #3225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrinkman
force-pushed
the
go/jbrinkman-randomize-cluster-ports
branch
from
0b3b79f to
397bffa
Compare
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
|
Your CI is red. Please don't forget to update CHANGELOG. |
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
Signed-off-by: jbrinkman <[email protected]>
jbrinkman
force-pushed
the
go/jbrinkman-randomize-cluster-ports
branch
from
ebb16b5 to
be68ac2
Compare
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: jbrinkman <[email protected]>
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: jbrinkman <[email protected]>
jbrinkman
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
|
|
||
| _, err = client.CustomCommand([]string{"FLUSHALL"}) // todo: replace with client.FlushAll() when implemented | ||
| // Flush the database before each test to ensure a clean state. | ||
| _, err := clusterClient.CustomCommand([]string{"FLUSHALL"}) // todo: replace with client.FlushAll() when implemented |
There was a problem hiding this comment.
consider adding all primaries route
| | tee >(go tool test2json -t -p github.com/valkey-io/valkey-glide/go/api \ | ||
| | go-test-report -o reports/example-tests.html -t example-test > /dev/null) | ||
| | go-test-report -o reports/example-tests.html -t example-test > /dev/null) |
There was a problem hiding this comment.
Need to stop server on failure
…ironments Signed-off-by: jbrinkman <[email protected]>
jbrinkman
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Comment on lines
+615
to
+616
| // LCS is only available in 7.0 and above. It will fail in any release < 7.0 | ||
| // 8.0 Output: h o |
There was a problem hiding this comment.
Maybe
Suggested change
| // LCS is only available in 7.0 and above. It will fail in any release < 7.0 | |
| // 8.0 Output: h o | |
| // LCS is only available in 7.0 and above. It will fail in any server < 7.0 | |
| // Output: h o |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (#3224)
Checklist
Before submitting the PR make sure the following are checked: