Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scoped RDB loading context and immediate abort flag #1173

Open
wants to merge 16 commits into
base: unstable
Choose a base branch
from
Open

Add scoped RDB loading context and immediate abort flag #1173

wants to merge 16 commits into from

Commits on Oct 29, 2024

  1. Add ASAP abort flag to provisional primary for safer replication disc… 

    …onnection handling

Introduces a dedicated flag in provisional primary struct to signal immediate
abort, preventing potential use-after-free scenarios during replication
disconnection in dual-channel load. This ensures proper termination of
rdbLoadRioWithLoadingCtx when replication is cancelled due to connection loss
on main connection.

Fixes valkey-io#1152

Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dec88f0 View commit details
    Browse the repository at this point in the history

  2. Update src/rio.h 

    Signed-off-by: Madelyn Olson <[email protected]>
    @madolson @naglera
    madolson authored and naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    61ab0a5 View commit details
    Browse the repository at this point in the history

  3. Consistently reproduce crash and improve test reliability 

    - Add test to consistently reproduce rdb load callback crash
- Avoid checking close_asap when no data was processed

Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4997941 View commit details
    Browse the repository at this point in the history

  4. Revert "Add ASAP abort flag to provisional primary for safer replicat… 

    …ion disconnection handling"

This reverts commit b873d41.

Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f89b716 View commit details
    Browse the repository at this point in the history

  5. Add scoped RDB loading context 

    This commit introduces a new mechanism for temporarily changing the
server's loading_rio context during RDB loading operations. The new
RDB_SCOPED_LOADING_RIO macro allows for a scoped change of the
server.loading_rio value, ensuring that it's automatically restored
to its original value when the scope ends.

Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    9849350 View commit details
    Browse the repository at this point in the history

  6. return 0 on async error during rioWrite (for symmetricality) 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    eba00eb View commit details
    Browse the repository at this point in the history

  7. Update src/server.h 

    Co-authored-by: ranshid <[email protected]>
Signed-off-by: Amit Nagler <[email protected]>
    @naglera @ranshid
    naglera and ranshid authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b82704f View commit details
    Browse the repository at this point in the history

  8. Fix comments 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4d8126b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Signal rio to be closed asap on connection state change 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    39f0217 View commit details
    Browse the repository at this point in the history

  2. Test fix- Wait for replica online 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    88466b6 View commit details
    Browse the repository at this point in the history

  3. typo fix 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    36ec221 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Update tests/integration/dual-channel-replication.tcl 

    Signed-off-by: Madelyn Olson <[email protected]>
    @madolson
    madolson authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    0af35e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Wrapper for rdbLoadRioWithLoadingCtx for scoped RDB 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    cd9dca0 View commit details
    Browse the repository at this point in the history

  2. Decrease rdb key save delay 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    43b1e22 View commit details
    Browse the repository at this point in the history

  3. after resetting rdb-key-save-delay to 0, don't expect to catch the re… 

    …plica while syncing (only expect it to be eventually connected)

Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    612e621 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Remove redundent logline set 

    Signed-off-by: naglera <[email protected]>
    @naglera
    naglera committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    90cde6b View commit details
    Browse the repository at this point in the history