RDMA builtin support

[pizhenwei]

Hi,

There are several patches in this PR:

• Abstract set/rewrite config bind option: bind option is a special config, socket and tls are using the same one. However RDMA uses the similar style but different one. Use a bit abstract work to make it flexible for both socket and RDMA. Even for QUIC in the future.
• Introduce closeListener for connection type: closing socket by a simple syscall would be fine, RDMA has complex logic. Introduce connection type specific close listener method.
• RDMA: Use valkey.conf style instead of module parameters: use --rdma-bind and --rdma-port style instead of module parameters.
• RDMA: Support builtin: support make BUILD_RDMA=yes. module style is still kept for now. Once module style is decided to drop, I volunteer to do it for TLS and RDMA together.

Each patch has independent functionality, also been tested by CI and local commands, so request no-squash merge for this PR.

[codecov]

Codecov Report

Attention: Patch coverage is 55.05618% with 40 lines in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (285064b) to head (047c7ec).
Report is 19 commits behind head on unstable.

Files with missing lines	Patch %	Lines
src/config.c	51.66%	29 Missing ⚠️
src/server.c	27.27%	8 Missing ⚠️
src/unix.c	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #1209      +/-   ##
============================================
- Coverage     70.72%   70.52%   -0.20%     
============================================
  Files           114      115       +1     
  Lines         63090    63152      +62     
============================================
- Hits          44621    44540      -81     
- Misses        18469    18612     +143     

Files with missing lines	Coverage Δ
src/connection.c	78.82% <100.00%> (+0.25%)	⬆️
src/connection.h	87.64% <100.00%> (+0.43%)	⬆️
src/rdma.c	100.00% <100.00%> (ø)
src/server.h	100.00% <ø> (ø)
src/socket.c	91.52% <100.00%> (+0.40%)	⬆️
src/tls.c	100.00% <ø> (ø)
src/unix.c	73.49% <0.00%> (-2.76%)	⬇️
src/server.c	88.50% <27.27%> (-0.25%)	⬇️
src/config.c	77.65% <51.66%> (-1.19%)	⬇️

... and 15 files with indirect coverage changes

[zuiderkwast]

@valkey-io/core-team Please approve.

This adds make BUILD_RDMA=yes, so just like TLS it can be built as a module or as builtin. Just like for TLS, the default is no.

It is a step towards official (non-experimantal) RDMA support.

I already merged the RDMA fork-safety here: #1244. It makes sure the server doesn't crash if we try to talk to an RDMA client from a forked child process.

[pizhenwei]

@valkey-io/core-team Please approve.

This adds make BUILD_RDMA=yes, so just like TLS it can be built as a module or as builtin. Just like for TLS, the default is no.

It is a step towards official (non-experimantal) RDMA support.

I already merged the RDMA fork-safety here: #1244. It makes sure the server doesn't crash if we try to talk to an RDMA client from a forked child process.

Hi @valkey-io/core-team
The CMake building support has been merged, then we can drop module build option for TLS and RDMA together.

[PingXie]

The CMake building support has been merged, then we can drop module build option for TLS and RDMA together.

I vote for dropping the module packaging. Modularity is what we need and we have it here for RDMA.

[zuiderkwast]

I believe it's safe to drop the RDMA module because it's experimental, but I'm not sure about the TLS module. Maybe someone is using it? Maybe we should drop it in a major version (9.0?).

The potential benefit of module is that you don't need OpenSSL installed to start Valkey, as long as you don't load the module. If we ship binary releases or containers with bundled modules, they can be used also by those who don't have or want TLS. Examples are embedded system, IoT devices, etc. We've already talked about packaging binaries with buldled modules like (bloom, json).