Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ZRANK to avoid path comparisons #1389

Merged
merged 8 commits into from
Dec 9, 2024

some refactor after PR comments

30a976e
Select commit
Loading
Failed to load commit list.
Merged

Optimize ZRANK to avoid path comparisons #1389

some refactor after PR comments
30a976e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 9, 2024 in 0s

70.84% (+0.01%) compared to 105509c

View this Pull Request on Codecov

70.84% (+0.01%) compared to 105509c

Details

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (105509c) to head (30a976e).
Report is 10 commits behind head on unstable.

Files with missing lines Patch % Lines
src/t_zset.c 96.22% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1389      +/-   ##
============================================
+ Coverage     70.83%   70.84%   +0.01%     
============================================
  Files           118      118              
  Lines         63549    63595      +46     
============================================
+ Hits          45013    45055      +42     
- Misses        18536    18540       +4     
Files with missing lines Coverage Δ
src/server.h 100.00% <ø> (ø)
src/t_zset.c 95.63% <96.22%> (-0.03%) ⬇️

... and 15 files with indirect coverage changes