Update governance and maintainers file for Valkey committers #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
sarthakaggarwal97
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1390 +/- ##
============================================
+ Coverage 70.60% 70.87% +0.26%
============================================
Files 116 118 +2
Lines 63264 63549 +285
============================================
+ Hits 44666 45038 +372
+ Misses 18598 18511 -87 |
Signed-off-by: Madelyn Olson <[email protected]>
Signed-off-by: Madelyn Olson <[email protected]>
zuiderkwast
approved these changes
Dec 4, 2024
madolson
changed the title
enjoy-binbin
approved these changes
Dec 5, 2024
soloestoy
approved these changes
Dec 5, 2024
|
I changed "maintainers" to "committers" in the top comment. And I noticed the use of repeated words like "so so" and "new new" in the top comment. Is this a new slang? |
hwware
approved these changes
Dec 5, 2024
I add a lot unnecessary words when I type and my brain never sees them :) |
vudiep411
pushed a commit
to Autxmaton/valkey
that referenced
this pull request
Dec 15, 2024
…io#1390) We added two more committers, but according to our governance document that makes them TSC members. As we discussed, for now we want to keep the balance of corporate interests, so so updating the governance to explicitly list TSC members compared to folks with just write permissions. Also adds the new new folks with commit permissions. --------- Signed-off-by: Madelyn Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added two more committers, but according to our governance document that makes them TSC members. As we discussed, for now we want to keep the balance of corporate interests, so so updating the governance to explicitly list TSC members compared to folks with just write permissions.
Also adds the new new folks with commit permissions.