Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in streams seen-time / active-time test #1409

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

romange
Copy link
Contributor

@romange romange commented Dec 8, 2024

This variable name is wrong, it causes the wrong variable to be asserted.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (e8078b7) to head (3ca64e9).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1409      +/-   ##
============================================
+ Coverage     70.78%   70.79%   +0.01%     
============================================
  Files           118      118              
  Lines         63561    63561              
============================================
+ Hits          44994    45001       +7     
+ Misses        18567    18560       -7     

see 14 files with indirect coverage changes

@enjoy-binbin enjoy-binbin changed the title fix: typo in streams active-time test Fix typo in streams seen-time / active-time test Dec 9, 2024
@enjoy-binbin enjoy-binbin merged commit b09db3e into valkey-io:unstable Dec 9, 2024
47 checks passed
vudiep411 pushed a commit to Autxmaton/valkey that referenced this pull request Dec 15, 2024
This variable name is wrong, it causes the wrong variable to be asserted.

Signed-off-by: Roman Gershman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants