-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix client trackinginfo crash when tracking off by default #1684
Fix client trackinginfo crash when tracking off by default #1684
Conversation
624c113
to
fd7e6fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1684 +/- ##
============================================
+ Coverage 71.02% 71.05% +0.03%
============================================
Files 121 121
Lines 65254 65313 +59
============================================
+ Hits 46344 46410 +66
+ Misses 18910 18903 -7
|
fd7e6fd
to
4087b28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uriyage please take a look
Checking the flag seems to be not enough. We got this in the CI job: Test case
|
@yangbodong22011 Can you fix the DCO issue? See the Details link next to the failing DCO CI job. There's some instructions about how to fix it. ( |
This pr will fix valkey-io#1683 After valkey-io#1405, cause this coredump. Signed-off-by: bodong.ybd <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: bodong.ybd <[email protected]>
Co-authored-by: Viktor Söderqvist <[email protected]> Signed-off-by: ranshid <[email protected]> Signed-off-by: bodong.ybd <[email protected]>
b9fe01d
to
8c2737b
Compare
Sorry for late, done. |
After #1405,
client trackinginfo
will crash when tracking is offThe reason is that we did not init pubsub_data by default, we only
init it when tracking on.
Fixes #1683.