Update rdb and module's child proc name to valkey accordingly (compatible with redis symlink) #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivshankar-Reddy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #454 +/- ##
============================================
+ Coverage 68.95% 69.81% +0.86%
============================================
Files 109 109
Lines 61793 61801 +8
============================================
+ Hits 42611 43149 +538
+ Misses 19182 18652 -530
|
|
Hi @zuiderkwast , Can you look at this when you have some time? |
zuiderkwast
reviewed
May 10, 2024
Signed-off-by: Shivshankar-Reddy <[email protected]>
zuiderkwast
changed the title
zuiderkwast
added
release-notes
hallmason17
pushed a commit
to hallmason17/valkey
that referenced
this pull request
May 15, 2024
…ible with redis symlink) (valkey-io#454) If `valkey-server` was started with the `redis-server` symlink, the old proc names are used, for backwards compatibility. --------- Signed-off-by: Shivshankar-Reddy <[email protected]>
hallmason17
pushed a commit
to hallmason17/valkey
that referenced
this pull request
May 18, 2024
…ible with redis symlink) (valkey-io#454) If `valkey-server` was started with the `redis-server` symlink, the old proc names are used, for backwards compatibility. --------- Signed-off-by: Shivshankar-Reddy <[email protected]>
srgsanky
pushed a commit
to srgsanky/valkey
that referenced
this pull request
May 19, 2024
…ible with redis symlink) (valkey-io#454) If `valkey-server` was started with the `redis-server` symlink, the old proc names are used, for backwards compatibility. --------- Signed-off-by: Shivshankar-Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
valkey-serverwas started with theredis-serversymlink, the old proc names are used, for backwards compatibility.