Delete dead code "zfree_usable" #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #518 +/- ##
============================================
- Coverage 69.85% 69.66% -0.19%
============================================
Files 109 109
Lines 61801 61797 -4
============================================
- Hits 43172 43052 -120
- Misses 18629 18745 +116
|
enjoy-binbin
approved these changes
May 20, 2024
enjoy-binbin
changed the title
zuiderkwast
approved these changes
May 20, 2024
adetunjii
pushed a commit
to adetunjii/valkey
that referenced
this pull request
May 22, 2024
Implemented in valkey-io@3945a32#diff-a154d1fa454a9868e2c455acdae971e3605151516f9a8efac7f2c9b2845d914d, this function is never called and never used. I was trying to understand whether we could use this for another PR, but couldn't really find a point for it because it didn't do exactly what I expected. Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Samuel Adetunji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in 3945a32#diff-a154d1fa454a9868e2c455acdae971e3605151516f9a8efac7f2c9b2845d914d, this function is never called and never used. I was trying to understand whether we could use this for another PR, but couldn't really find a point for it because it didn't do exactly what I expected.